Skip to content

feat: POST messages to companion backend#3742

Merged
mrCherry97 merged 9 commits intokyma-project:mainfrom
chriskari:post-messages
Mar 11, 2025
Merged

feat: POST messages to companion backend#3742
mrCherry97 merged 9 commits intokyma-project:mainfrom
chriskari:post-messages

Conversation

@chriskari
Copy link
Contributor

@chriskari chriskari commented Mar 4, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • adjusted format of API request
  • API request is proxied through our backend
  • use correct Authorization headers (token vs. client-certificate and client-key)

Related issue(s)
#3605

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 4, 2025
@chriskari chriskari linked an issue Mar 4, 2025 that may be closed by this pull request
Integrate and adjust POST /conversations/{conversation_id}/messages endpoint #3605
Closed
5 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 4, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 4, 2025
View reviewed changes
akucharska
akucharska reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should Joule behave when switching page?
When we open different resource without asking any question we get new suggestions. But if we ask AI a question and go to different page we see our old conversation. Is this correct?

Screen.Recording.2025-03-07.at.15.09.48.mov

@chriskari
Copy link
Contributor Author

chriskari commented Mar 9, 2025

How should Joule behave when switching page? When we open different resource without asking any question we get new suggestions. But if we ask AI a question and go to different page we see our old conversation. Is this correct?

Screen.Recording.2025-03-07.at.15.09.48.mov

Yes this behaviour is correct. We keep track of the current resource, and if the user switches a resource during conversation, the next API request to the companion backend will send the updated resource information, but the conversation should persist. The only ways that the chat history can be cleared right now, should be the reset-button on top (yet to be implemented) or closing and re-opening the companion.

@KonradPietocha
Copy link
Contributor

KonradPietocha commented Mar 10, 2025

How should Joule behave when switching page? When we open different resource without asking any question we get new suggestions. But if we ask AI a question and go to different page we see our old conversation. Is this correct?
Screen.Recording.2025-03-07.at.15.09.48.mov

Yes this behaviour is correct. We keep track of the current resource, and if the user switches a resource during conversation, the next API request to the companion backend will send the updated resource information, but the conversation should persist. The only ways that the chat history can be cleared right now, should be the reset-button on top (yet to be implemented) or closing and re-opening the companion.

So this reset button will be implemented in some future task, right?

@chriskari
Copy link
Contributor Author

chriskari commented Mar 10, 2025

How should Joule behave when switching page? When we open different resource without asking any question we get new suggestions. But if we ask AI a question and go to different page we see our old conversation. Is this correct?
Screen.Recording.2025-03-07.at.15.09.48.mov

Yes this behaviour is correct. We keep track of the current resource, and if the user switches a resource during conversation, the next API request to the companion backend will send the updated resource information, but the conversation should persist. The only ways that the chat history can be cleared right now, should be the reset-button on top (yet to be implemented) or closing and re-opening the companion.

So this reset button will be implemented in some future task, right?

#3748

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 10, 2025
@mrCherry97 mrCherry97 enabled auto-merge (squash) March 11, 2025 07:52
@mrCherry97 mrCherry97 disabled auto-merge March 11, 2025 10:36
@mrCherry97 mrCherry97 merged commit 38845ad into kyma-project:main Mar 11, 2025
20 checks passed
@chriskari chriskari deleted the post-messages branch March 26, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akucharska akucharska akucharska approved these changes

@KonradPietocha KonradPietocha KonradPietocha approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

@KonradPietocha KonradPietocha

Labels

lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate and adjust POST /conversations/{conversation_id}/messages endpoint

5 participants

@chriskari @KonradPietocha @akucharska @kyma-bot @mrCherry97